Wait pty readable if there may be data to read #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Sep 28, 2024
| @@ -89,7 +92,10 @@ def close | |||
| private def sync(wait = @wait) | |||
| sync_until = Time.now + @timeout | |||
| while @pty_output.wait_readable(wait) | |||
| vterm_write(@pty_output.read_nonblock(65536)) | |||
| @pty_output.wait_readable(sync_until - Time.now) if @maybe_read | |||
There was a problem hiding this comment.
@pty_output.wait_readable(sync_until - Time.now) seems to have no effect.
This code is inside while @pty_output.wait_readable(wait) so @pty_output is already readable.
|
Thank you for investigating. For query/response order, as described in #22 (comment), I think it is acceptable, and I also think it is hard to fix. (Sorry if my understanding is wrong.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait pty readable after pty write to keep vterm query/response order and to avoid early close.
fixes #22